Skip to content

Correct jira_update_issue example for assignee format #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025

Conversation

eran-rom
Copy link
Contributor

@eran-rom eran-rom commented Apr 25, 2025

Description

This PR corrects the example JSON provided in the jira_update_issue tool description within src/mcp_atlassian/server.py. The previous example incorrectly showed the assignee value as a dictionary ({"name": "..."}). This was inconsistent with the implementation in IssuesMixin.update_issue, which expects a string identifier (username, email, or account ID) for the assignee.

This incorrect example caused runtime error, AttributeError: 'dict' object has no attribute 'startswith', when the tool was used with the assignee provided as a dictionary. This fix resolves the inconsistency and prevents this error.

Changes

  • Corrected the assignee example format in the jira_update_issue tool description (server.py).

Testing

  • Unit tests added/updated
  • Integration tests passed
  • Manual checks performed: Confirmed the fix works when using the jira_update_issue tool via Cursor MCP.

Checklist

  • Code follows project style guidelines (linting passes).
  • Tests added/updated for changes.
  • All tests pass locally.
  • Documentation updated (if needed).

Copy link
Owner

@sooperset sooperset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this inconsistency and providing the fix!

@sooperset sooperset merged commit cd7b380 into sooperset:main Apr 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants