fix(jira): Use enhanced_jql for Cloud searches and fix startAt TypeError #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the `SearchMixin.search_issues` method to conditionally use the appropriate Jira API method based on the instance type: - For Jira Cloud (`config.is_cloud == True`), it now calls `enhanced_jql`, removing the unsupported `start` keyword argument. - For Jira Server/DC (`config.is_cloud == False`), it continues to use the `jql` method with the `start` argument for pagination. This resolves the `TypeError: enhanced_jql() got an unexpected keyword argument 'start'` reported when searching issues on Jira Cloud with pagination parameters. Note: As `enhanced_jql` does not support the `startAt` offset, pagination using the `startAt` parameter in the `jira_search` tool will effectively be ignored for Jira Cloud instances, always returning the first page. This limitation is documented in the method's docstring.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the TypeError:
enhanced_jql() got an unexpected keyword argument 'start'error when using jira_search with startAt in Jira Cloud. The enhanced_jql method from atlassian-python-api doesn't support the start parameter.Also updates atlassian-python-api dependency to version >=4.0.0.
Refs: #347
Changes
Testing
[Verified behavior in both Cloud and Server environments]Checklist