Skip to content

unicode_info: remove plugin in favor of external package #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

unicode_info: remove plugin in favor of external package #2674

merged 1 commit into from
May 9, 2025

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented May 4, 2025

Description

This changeset removes the unicode_info plugin, in line with #1291, to be replaced by the sopel-unicode plugin.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches
    • I removed my exclude conrfig and sopel-unicode from my test instance, installed against this diff, and the command was not present.

@SnoopJ SnoopJ requested a review from a team May 4, 2025 04:06
@dgw dgw mentioned this pull request Apr 25, 2025
Open
40 tasks
@dgw dgw added this to the 8.1.0 milestone May 4, 2025
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label May 4, 2025
dgw
dgw approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little nuts that we didn't have any tests attached to this plugin. (Beyond the examples, that is.) Makes the extraction simple, though!

Exirel
Exirel approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SnoopJ SnoopJ added the Breaking Change Stuff that probably should be mentioned in a migration guide label May 8, 2025
@dgw dgw merged commit 97bb97c into sopel-irc:master May 9, 2025
17 checks passed
@SnoopJ SnoopJ deleted the chore/gh-1291_remove-unicode_info branch May 12, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SnoopJ @dgw @Exirel