Skip to content

set engines and adjust ci + documentation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

set engines and adjust ci + documentation #38

merged 1 commit into from
Jan 18, 2023

Conversation

Ethan-Arrowood
Copy link
Collaborator

@Ethan-Arrowood Ethan-Arrowood commented Jan 17, 2023 •
edited
Loading

Closes #34 #35

@Ethan-Arrowood
Copy link
Collaborator Author

@Cadienvan would you like to review this and co-author the commit with me? Your work in #34 and #35 is good and I want to give credit where credit is deserved 😄

Cadienvan
Cadienvan approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Cadienvan Cadienvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems perfect to me! Brilliant, I didn't think about the experimental flag!

@Cadienvan
Copy link
Contributor

Cadienvan commented Jan 18, 2023 •
edited
Loading

Thank you for your kindness! Sure! I reviewed it, dunno how to co-author it :D Is it enough for you to bring a co-authored-by in the commit message when merging?

@Ethan-Arrowood
Copy link
Collaborator Author

I will amend the commit so its included in the merge :)

@Ethan-Arrowood Ethan-Arrowood merged commit 0cec426 into master Jan 18, 2023
@Ethan-Arrowood Ethan-Arrowood deleted the add/engines branch January 18, 2023 15:49
@Cadienvan
Copy link
Contributor

Thanks! So can I delete my branches now?

@trevor-scheer trevor-scheer mentioned this pull request Jan 25, 2023
Closed
yannbf added a commit to yannbf/node-abort-controller that referenced this pull request Jan 26, 2023
@yannbf
Revert "set engines and adjust ci + documentation (southpolesteve#38)"
91226f7 
This reverts commit 0cec426.
@yannbf yannbf mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadienvan Cadienvan Cadienvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ethan-Arrowood @Cadienvan