pedantic clippy cleanup

[spacejam]

There are many issues when running cargo clippy -- -W clippy::pedantic from the root. Most of them are quite easy to fix (please ignore cyclometric complexity issues).

Please help us clean some of them up! Even a single one is helpful!

[sitano]

do you think pedantic naming worth it? (pid <-> lid, lsn <-> len are forbidden)

[spacejam]

@sitano Personally I'm fine with these abbreviations because I've seen them every day for the last 3 years, but I think for other people they might not be very descriptive. pid would probably be better as page_id, lid would probably be better as log_id. But lsn and len though are both kind of idiomatic (LSN in the database world is pretty ubiquitous). So I think that renaming is not worth it for lsn and len, but pid and lid could probably be less confusing for newcomers to the codebase.

[sitano]

@spacejam thats exactly what I did) agree that all that idiomatic stuff does not make sense to rename. I thought that even pid does not worth it.

[sitano]

as far as I saw, there is nothing to fix there anymore. only integer ops related stuff left, naming with module and use of default - all this unfixable. maybe its worth creating another execution string for clippy with all current warns that left allowed, because there is no chance find anything useful behind this wall of integer devisions and precision losts.