This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Prevent decoding the uuid when the model does not exist #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendt
suggested changes
Feb 28, 2018
| return array_merge(parent::toArray(), [$this->getKeyName() => $this->uuid_text]); | ||
| } | ||
|
|
||
| public function getUuidTextAttribute(): string |
There was a problem hiding this comment.
This method should be type hinted as a nullable string:
public function getUuidTextAttribute(): ?stringThere was a problem hiding this comment.
Nullable types are not available in PHP 7.0. Do you want me to change php requirement in the composer.json file?
There was a problem hiding this comment.
Sorry I missed that, yes feel free to bump the PHP version!
There was a problem hiding this comment.
Done 👍 I've changed Travis configuration as well. Yolo, right?
src/HasBinaryUuid.php
Outdated
| { | ||
| if (! $this->exists) { | ||
| return; |
There was a problem hiding this comment.
null should be returned here.
src/HasBinaryUuid.php
Outdated
| @@ -6,6 +6,9 @@ | |||
| use Illuminate\Database\Eloquent\Model; | |||
| use Illuminate\Database\Eloquent\Builder; | |||
|
|
|||
| /** | |||
| * @property string|null $uuid_text | |||
There was a problem hiding this comment.
This docblock should be removed as $uuid_text isn't always the name of the textual property.
|
🎊Thanks! |
|
Released and tagged: https://github.com/spatie/laravel-binary-uuid/releases/tag/1.1.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #39.