-
-
Notifications
You must be signed in to change notification settings - Fork 29
Add exception for SVG images #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just signal-boosting this. I'd recommend a patch release just after. As-is, anybody that was using an |
1 similar comment
Just signal-boosting this. I'd recommend a patch release just after. As-is, anybody that was using an |
Can we have a test for this so anything similar doesn't bit us in the future? |
OK the latest push adds a test that fails on |
I think this is a minimal patch to avoid breaking when a user has an SVG image. Ideally we would catch this and raise a warning in Sphinx, but I wanted to show the minimal patch to avoid the bug if you wanna make a patch release. I likely don't have time to do a proper implementation w/ a warning and such (am expecting a baby any day now)