Skip to content

update maintainers #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/.spelling
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ ovs
kube-ovn
subent
roadmap
Icarus9913
iiiceoo
excludeIPs
replicaset
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Bug Report
description: Report a bug that you encountered
labels: ["kind/bug"]
assignees: ["Icarus9913", "cyclinder"]
assignees: ["cyclinder"]
body:
- type: markdown
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Feature Request
description: Provide supporting details for a feature in development Spiderpool
labels: ["kind/feature"]
assignees: ["Icarus9913", "cyclinder"]
assignees: ["cyclinder"]
body:
- type: markdown
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-diff-k8s-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
body: |
action url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
labels: "kind/ci-bug"
assignees: "Icarus9913,ty-dc"
assignees: "ty-dc"

call_inputs_k8s:
# workflow_dispatch event flow triggered by running the input k8s version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-nightly-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,4 +206,4 @@ jobs:
body: |
action url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
labels: "kind/ci-bug"
assignees: "Icarus9913,ty-dc"
assignees: "ty-dc"
6 changes: 3 additions & 3 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
* @weizhoublue
/.github/ @weizhoublue
/api/ @weizhoublue @Icarus9913
/api/ @weizhoublue
/charts/ @weizhoublue
/cmd/ @weizhoublue @Icarus9913
/cmd/ @weizhoublue
/contrib/ @weizhoublue
/docs/ @weizhoublue @windsonsea @Michelle951 @Jeanine-tw
/images/ @weizhoublue
/pkg/ @weizhoublue @Icarus9913
/pkg/ @weizhoublue
/test/ @weizhoublue
/test/e2e/ @weizhoublue @ty-dc @bzsuni
/test/doc/ @weizhoublue @ty-dc @bzsuni
Expand Down
1 change: 0 additions & 1 deletion MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@ Please see the [AUTHORS](./AUTHORS) file for the full list of contributors to th
| [Weizhou Lan](https://github.com/weizhoublue) | Daocloud |
| [Cyclinder](https://github.com/cyclinder ) | Daocloud |
| [Michael](https://github.com/windsonsea) | Daocloud |
| [Lcarus](https://github.com/Icarus9913) | Daocloud |
| [Tao Yang](https://github.com/ty-dc) | Daocloud |
| [Kai Yan](https://github.com/yankay) | Daocloud |
1 change: 0 additions & 1 deletion pkg/gcmanager/pod_cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ func (p *PodDatabase) ApplyPodEntry(podEntry *PodEntry) error {
podCache, ok := p.pods[ktypes.NamespacedName{Namespace: podEntry.Namespace, Name: podEntry.PodName}]
if !ok {
if len(p.pods) == p.maxCap {
// TODO (Icarus9913): add otel metric
p.Unlock()
return fmt.Errorf("podEntry database is out of capacity, discard podEntry '%+v'", *podEntry)
}
Expand Down
1 change: 0 additions & 1 deletion pkg/multuscniconfig/multusconfig_informer.go
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@ func generateMacvlanCNIConf(disableIPAM bool, multusConfSpec spiderpoolv2beta1.M
}
}

// TODO(Icarus9913): customize the macvlan mode
netConf := MacvlanNetConf{
Type: constant.MacvlanCNI,
Master: masterName,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/kubevirt/kubevirt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ var _ = Describe("test kubevirt", Label("kubevirt"), func() {
Expect(vmInterfaces).Should(Equal(tmpVMInterfaces))
})

// TODO (Icarus9913): after migration, the new vm pod try to pull a different tag image which may cause image pull failed.
// TODO (ty-dc): after migration, the new vm pod try to pull a different tag image which may cause image pull failed.
PIt("Succeed to keep static IP for the kubevirt VM live migration", Label("F00002"), func() {
// 1. create a kubevirt vm with masquerade mode (At present, it seems like the live migration only supports masquerade mode)
virtualMachine.Spec.Template.Spec.Networks = []kubevirtv1.Network{
Expand Down
Loading