Skip to content

chore: update wfe-base and set up git safe directory #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

mbruzda-splunk
Copy link
Contributor

@mbruzda-splunk mbruzda-splunk commented Feb 22, 2024

Image 2.0.12 uses git 2.39 and 2.0.3 uses 2.32. This error was intoduced with git 2.36. It requires setting up safe directory (probably here is some other way to fix it, but this works)

Tested here:

@mbruzda-splunk mbruzda-splunk marked this pull request as ready for review February 23, 2024 10:36
@mbruzda-splunk mbruzda-splunk requested a review from a team as a code owner February 23, 2024 10:36
@mkolasinski-splunk
Copy link
Contributor

@mbruzda-splunk please put a comment in the code to explain what is the purpose of this step.
@artemrys we could also change user permissions in image, not sure which choice is better https://cd.splunkdev.com/core-ee/workflow-engine/workflow-engine-images/-/blob/main/dockerfiles/workflow-engine-base/Dockerfile?ref_type=heads#L21

@artemrys
Copy link
Member

@mbruzda-splunk please put a comment in the code to explain what is the purpose of this step. @artemrys we could also change user permissions in image, not sure which choice is better https://cd.splunkdev.com/core-ee/workflow-engine/workflow-engine-images/-/blob/main/dockerfiles/workflow-engine-base/Dockerfile?ref_type=heads#L21

Good point @mkolasinski-splunk, can you please follow up with Helena and ask her why she designed it like that? She was the last one to touch that line of code.

@artemrys artemrys merged commit fc32449 into develop Feb 28, 2024
@artemrys artemrys deleted the chore/update_wfe_base branch February 28, 2024 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants