Skip to content

Fixed some bugs #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2021
Merged

Fixed some bugs #1326

merged 4 commits into from
Jun 26, 2021

Conversation

xnetcat
Copy link
Member

@xnetcat xnetcat commented Jun 26, 2021

Title

Fixed some bugs

Description

Fixed never ending loop in get artist tracks, changed how we check for track id

Related Issue

Motivation and Context

bugs are not ok

How Has This Been Tested?

pytest, mypy, flake8

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@xnetcat xnetcat requested a review from Silverarmor June 26, 2021 10:09
@Silverarmor Silverarmor merged commit 16e0ad9 into spotDL:dev Jun 26, 2021
@Silverarmor Silverarmor added the Bug Fix PRs that fix bugs label Jun 26, 2021
@xnetcat xnetcat deleted the id-is-none-fix branch July 16, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants