Skip to content

gitignore update and update tests for multithread search #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2021
Merged

gitignore update and update tests for multithread search #1398

merged 2 commits into from
Oct 20, 2021

Conversation

Silverarmor
Copy link
Member

@Silverarmor Silverarmor commented Oct 15, 2021 •
edited
Loading

Also remove old .cache

running pytest --cov=spotdl to check coverage creates a .coverage file which should not be tracked by git

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@Silverarmor
Add test coverage file to gitignore
916fb33 
Also remove old .cache
@Silverarmor Silverarmor changed the title Add test coverage file to gitignore gitignore update and update tests for multithread search Oct 19, 2021
@Silverarmor Silverarmor requested a review from xnetcat October 19, 2021 09:48
@Silverarmor Silverarmor added the Bug Fix PRs that fix bugs label Oct 19, 2021
@Silverarmor Silverarmor requested a review from s1as3r October 20, 2021 05:21
@xnetcat xnetcat merged commit 0bb6656 into spotDL:dev Oct 20, 2021
@Silverarmor Silverarmor deleted the update-gitignoroe branch October 20, 2021 07:58
Silverarmor added a commit that referenced this pull request Oct 24, 2021
@Silverarmor @xnetcat
@yezz123 @phcreery @s1as3r
Merge pull request #1393 from spotDL/dev
8474fee 
* bugfix: don't add cover if spotify does not provide album cover (#1384)


* 🪶: Refactor Code Expression (#1390)
Co-authored-by: Silverarmor <[email protected]>
Co-authored-by: Jakub Kot <[email protected]>
Co-authored-by: Peyton Creery <[email protected]>


* bugfix: replace rapidfuzz with thefuzz (#1391)


* gitignore update and update tests for multithread search (#1398)


* misc improvements (#1392)
This reverts commit 5787bea.
Co-authored-by: Silverarmor <[email protected]>


* Multiple Lyrics Providers (#1397)
Co-authored-by: Silverarmor <[email protected]>
Co-authored-by: Jakub Kot <[email protected]>


* misc: fix warnings (#1400)


* revert bea748b: revert to rapidfuzz (#1403)


* ci: cleanup (#1402)


* feat: added path template (#1401)
Co-authored-by: Silverarmor <[email protected]>


Co-authored-by: Jakub Kot <[email protected]>
Co-authored-by: Yasser Tahiri <[email protected]>
Co-authored-by: Peyton Creery <[email protected]>
Co-authored-by: Arbaaz Shafiq <[email protected]>
Co-authored-by: Jakub Kot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnetcat xnetcat xnetcat approved these changes

@s1as3r s1as3r Awaiting requested review from s1as3r

Assignees
No one assigned
Labels
Bug Fix PRs that fix bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silverarmor @xnetcat