Make --save-errors append to file instead of overwriting #2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes: - Always include filter when sending requests to piped by @xnetcat - Check status code when getting response from piped by @xnetcat - Use piped.video instead of main piped instance by @j3bx in spotDL#2172 - Fixed `RuntimeError: Directory 'C:\Users\myuser\.spotdl\web-ui\dist' does not exist` by @R0GUE-A5H in spotDL#2173 - Make sync command aware of file name changes by @xnetcat Documentation: - Chore: update downloader.py by @Elto Co-authored-by: kuba <[email protected]> Co-authored-by: Alan <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Ash <[email protected]>
|
Maybe add a timestamp before writing the errors, so that it's easier to look through the error file. |
|
@xnetcat Is this what you had in mind? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Make --save-errors append to file instead of overwriting
Description
File open mode "w" -> "a" and an extra newline to make sure errors are printed on different lines
Related Issue
#2197
Motivation and Context
See issue
How Has This Been Tested?
Ran spotDL multiple times to generate errors over multiple runs.
Screenshots (if appropriate)
Types of Changes
Checklist