feat: Add additional PR field in CheckRunResponse and CheckSuite #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
============================================
- Coverage 77.41% 76.73% -0.68%
Complexity 433 433
============================================
Files 60 60
Lines 1368 1380 +12
Branches 60 60
============================================
Hits 1059 1059
- Misses 265 277 +12
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Abhi347
force-pushed
the
feat/add-additional-pr-field-checks
branch
from
a1b691f to
5170ff4
Compare
Abhi347
force-pushed
the
feat/add-additional-pr-field-checks
branch
from
5170ff4 to
3ca45e5
Compare
honnix
reviewed
Apr 29, 2025
| @JsonDeserialize(as = ImmutablePartialPullRequestItem.class) | ||
| public interface PartialPullRequestItem extends CloseTracking { | ||
| /** ID. */ | ||
| Long id(); |
There was a problem hiding this comment.
This introduced a breaking change because they were all optional.
honnix
reviewed
Apr 29, 2025
| URI url(); | ||
|
|
||
| /** Number. */ | ||
| Long number(); |
There was a problem hiding this comment.
This changes from Integer to Long, which is also a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pull_requestsfield to both CheckRunResponse and CheckSuite classPartialPullRequestItemwhich is usually part of thepull_requestsfield in check runs as they don't have the complete PR object.