Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Remove bootstrap from logout page #1867

Closed
oodamien opened this issue Jun 30, 2022 · 1 comment · Fixed by #1868
Closed

Remove bootstrap from logout page #1867

oodamien opened this issue Jun 30, 2022 · 1 comment · Fixed by #1868
Assignees
@oodamien

Comments

@oodamien
Copy link
Contributor

Bootstrap isn't used anywhere else and we should rather remove it or include the files in our project as assets.
Backport to 2.10.x, 2.9.x and 2.8.x
@oodamien oodamien self-assigned this Jun 30, 2022
oodamien added a commit to oodamien/spring-cloud-dataflow-ui that referenced this issue Jun 30, 2022
@oodamien
fix: Remove bootstrap from logout page
c465d04 
Resolves spring-attic#1867
@oodamien oodamien mentioned this issue Jun 30, 2022
Merged
corneil pushed a commit that referenced this issue Jun 30, 2022
Merge pull request #1868 from oodamien/fix/gh-1867
7292106 
fix: Remove bootstrap from logout page
claudiahub pushed a commit to claudiahub/spring-cloud-dataflow-ui that referenced this issue Jul 8, 2022
@oodamien @claudiahub
fix: Remove bootstrap from logout page
bc23859 
Resolves spring-attic#1867
onobc pushed a commit to onobc/spring-cloud-dataflow-ui that referenced this issue Jul 8, 2022
@oodamien @onobc
Remove bootstrap from logout page (backport spring-attic#1867)
2cc848b 
* Backport of spring-attic@c465d04

Resolves spring-attic#1871
onobc pushed a commit to onobc/spring-cloud-dataflow-ui that referenced this issue Jul 8, 2022
@oodamien @onobc
Remove bootstrap from logout page (backport spring-attic#1867)
4627a18 
* Backport of spring-attic@c465d04

Fixes spring-attic#1871
onobc added a commit that referenced this issue Jul 8, 2022
@onobc @oodamien
Remove bootstrap from logout page (backport #1867) (#1876)
85e125f 
* Backport of c465d04

Fixes #1871

Co-authored-by: Damien Vitrac <[email protected]>
@klopfdreh
Copy link
Contributor

klopfdreh commented Sep 26, 2022 •
edited
Loading

Hey @onobc and @oodamien - I am currently testing 2.10.0-M2 and what I noticed is that you removed bootstrap from logout page, but in login page it is still present. It should be removed from there, too so that bootstrap is not used any longer.

@klopfdreh klopfdreh mentioned this issue Sep 26, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@oodamien oodamien

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove bootstrap from logout page oodamien/spring-cloud-dataflow-ui
2 participants
@oodamien @klopfdreh