Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Update spring-shell 2.1.x #4795

Closed
jvalkeal opened this issue Jan 6, 2022 · 1 comment
Closed

Update spring-shell 2.1.x #4795

jvalkeal opened this issue Jan 6, 2022 · 1 comment
Assignees
@onobc
Milestone
2.10.0-M2

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Jan 6, 2022 •
edited
Loading

This is a proper fix for #4783
@jvalkeal jvalkeal added this to the 2.10.0-M2 milestone Jan 6, 2022
jvalkeal added a commit that referenced this issue Jan 6, 2022
@jvalkeal
Enable allow-circular-references for shell
2eeba7a 
- This is a temporary workaround before we've able
  to implement #4795
- Fixes #4783
@onobc onobc assigned onobc and unassigned jvalkeal Feb 4, 2022
@jvalkeal jvalkeal changed the title Update spring-shell 3.x Update spring-shell 2.1.x Feb 8, 2022
jvalkeal added a commit that referenced this issue Feb 22, 2022
@jvalkeal
Polish shell logging
ba471d9 
- Relates #4795
jvalkeal added a commit that referenced this issue Feb 23, 2022
@jvalkeal
Add custom ResultHander for multi-table
b154b31 
- For now instead of trying to handle this centrally
  in spring-shell add quick fix via custom handler.
- Relates #4795
@onobc
Copy link
Contributor

onobc commented Apr 15, 2022

Closed via b651e07

@onobc onobc closed this as completed Apr 15, 2022
jvalkeal added a commit that referenced this issue May 12, 2022
@jvalkeal
Fix shell commands with tables and strings
f73cbd0 
- Use custom holder TablesInfo and TablesInfoResultHandler
  to properly handle old style List<Object> which contained
  Tables and Strings.
- Original fix in #4795 wasn't that create work which caused
  some commands to break.
- Fixes #4909
@markpollack markpollack modified the milestones: 2.10.0-M2, 2.10.0-M3 Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@onobc onobc

Labels
None yet
Milestone
2.10.0-M2
Development

No branches or pull requests
3 participants
@jvalkeal @markpollack @onobc