Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Add Back support for mysql 5.7 #4879

Closed
markpollack opened this issue Apr 7, 2022 · 5 comments
Closed

Add Back support for mysql 5.7 #4879

markpollack opened this issue Apr 7, 2022 · 5 comments
Assignees
Labels
status/in-progress Something is happening
Milestone

Comments

@markpollack
Copy link
Contributor

TBD

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Apr 7, 2022
@onobc onobc self-assigned this Apr 14, 2022
@onobc
Copy link
Contributor

onobc commented Apr 22, 2022

I was able to get 2.9.x SCDF running against MySQL 5.7 using the Flyway Teams edition.

Here is what I did:

Current (base case lets prove its broken)

  • Start MySQL 5.7
  • Start SCDF 2.9.x w/ MariaDB driver pointing to MySQL 5.7
  • BIG 💥 💥 EXPLOSION - no 🎲 !!

With Flyway Teams

  • Obtain a Flyway Teams trial license
  • Change Flyway dependency in spring-cloud-dataflow-common-flyway
  • Set Flyway license in env var
  • Start MySQL 5.7
  • Start SCDF 2.9.x w/ MariaDB driver pointing to MySQL 5.7
  • NO explosions - just 💰 profit!!!

Next Steps

Make this work in PRO only. Will do this next week.

@onobc
Copy link
Contributor

onobc commented Apr 22, 2022

ℹ️ SB 2.5.12 runs w/ Flyway 7.7.3 but the trial license only works w/ 8.x so I used the 8.0.5 Flyway version. I am sure we could get l license for the 7.7.3 version if need be.

I will figure out which version we are currently using in 2.9.x.

SB version Flyway version
2.5.12 7.7.3
2.6.6 8.0.5
2.7.0-RC1 8.5.9

@onobc
Copy link
Contributor

onobc commented Apr 27, 2022

I have this working for MySQL 5.7 + SB 2.6.6 + Flyway Teams. I will get it ready in a PR.

onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Apr 27, 2022
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Apr 27, 2022
@markpollack markpollack added status/in-progress Something is happening and removed status/need-triage Team needs to triage and take a first look labels May 4, 2022
@markpollack markpollack added this to the 2.10.0-M2 milestone May 4, 2022
@onobc
Copy link
Contributor

onobc commented May 12, 2022

[Implementation Note]: We may be able to always use the Flyway teams lib and set the "edition" property to community in the non-pro case. This would allow us to not worry about using different libs in PRO/OSS. This would be good because we do not have a Pro Skipper and therefore would have to deploy 2 skipper libs (w/ and w/o teams lib).

The hope is the "Warning" message about teams goes away when using the "edition=community" setting.

onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue May 16, 2022
@markpollack markpollack modified the milestones: 2.10.0-M2, 2.10.0-M3 Aug 17, 2022
@onobc onobc changed the title Add Back support for mysql 5.7 with the commercial flyway library Add Back support for mysql 5.7 Aug 24, 2022
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Aug 31, 2022
@onobc
Copy link
Contributor

onobc commented Sep 7, 2022

Closed via 8ab2b1e

@onobc onobc closed this as completed Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/in-progress Something is happening
Development

Successfully merging a pull request may close this issue.

2 participants