Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Please don't update ubuntu packages within the docker-compose #4915

Closed
alexanderankin opened this issue May 18, 2022 · 5 comments
Closed

Please don't update ubuntu packages within the docker-compose #4915

alexanderankin opened this issue May 18, 2022 · 5 comments
Assignees
Labels
type/task Something needs to get done
Milestone

Comments

@alexanderankin
Copy link

Problem description:
The problem I'm seeing is very high cpu usage when i reboot my pc, htop says it is the containers from the getting started guide of this project.

Solution description:
I think the solution here is to simply not run apt-get update in the docker-compose file. I can submit a PR which fixes this and simply waits for the port instead of downloading a dependency to do it

Description of alternatives:
An alternative is to add this to the images used:

https://github.com/spring-cloud/spring-cloud-dataflow/blob/0b9ff6024c2983f63e16ab5709c697af31a0203f/src/docker-compose/docker-compose.yml#L57

https://github.com/spring-cloud/spring-cloud-dataflow/blob/0b9ff6024c2983f63e16ab5709c697af31a0203f/src/docker-compose/docker-compose.yml#L124

it seems like somehow this script already exists in this image, for instance:

https://github.com/spring-cloud/spring-cloud-dataflow/blob/0b9ff6024c2983f63e16ab5709c697af31a0203f/src/docker-compose/docker-compose.yml#L111-L120

Additional context:
seems like updating ubuntu packages on multiple containers detracts from the overall introductory experience

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label May 18, 2022
@markpollack markpollack added type/task Something needs to get done and removed status/need-triage Team needs to triage and take a first look labels May 24, 2022
@markpollack markpollack added this to the 2.10.0-M2 milestone May 24, 2022
@alexanderankin
Copy link
Author

btw here's how you'd do it - alexanderankin/docker-compose-waiting@c24d20b

@alexanderankin
Copy link
Author

@markpollack - i should submit a pr for this right? I could get to it within the coming week

@markpollack
Copy link
Contributor

sure, basically we just need to remove apt-get update in the docker compose file as it is already performed when creating the base image.

@corneil
Copy link
Contributor

corneil commented Aug 30, 2022

See PR #5069

markpollack pushed a commit to markpollack/spring-cloud-dataflow that referenced this issue Sep 6, 2022
@onobc
Copy link
Contributor

onobc commented Sep 8, 2022

Closed via 50c5937

@onobc onobc closed this as completed Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/task Something needs to get done
Development

No branches or pull requests

4 participants