You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 14, 2025. It is now read-only.
Nirvandil
changed the title
Semicoln in docker registry brokes detection of WWW-Authorization URL in DockerConfigJsonSecretToRegistryConfigurationConverter
Semicolon (port) in docker registry URI brokes detection of WWW-Authorization URL in DockerConfigJsonSecretToRegistryConfigurationConverter
Oct 10, 2022
Nirvandil
changed the title
Semicolon (port) in docker registry URI brokes detection of WWW-Authorization URL in DockerConfigJsonSecretToRegistryConfigurationConverter
Colon (port) in docker registry URI brokes detection of WWW-Authorization URL in DockerConfigJsonSecretToRegistryConfigurationConverter
Oct 11, 2022
Description:

Hi there.
I'm using scdf in k8s.
Having something like this in .dockerjson secret
{ "auths": { "registry.somedomain.com:5050": { "username": "kubernetes-puller", "password": "somePassword" } } }
leads to org.springframework.cloud.dataflow.container.registry.authorization.DockerConfigJsonSecretToRegistryConfigurationConverter#getDockerTokenServiceUri fail to detect right URL.
Especially, it passes registry.somedomain.com:5050 (with port!) as host variable to UriComponentsBuilder, so later it detected as IPv6 address in URI.java:
which leads to adding brackets to the URI and then (on build URI) throwing exception because it's invalid IPv6 address obviously. This exception then is swallowed here org/springframework/cloud/dataflow/container/registry/authorization/DockerConfigJsonSecretToRegistryConfigurationConverter.java:212 silently returning Optional.empty().
Release versions:
2.9.6
Steps to reproduce:
Just add custom docker registry with port in his address and see DockerConfigJsonSecretToRegistryConfigurationConverter detects it as basicauth instead of dockeroauth2
The text was updated successfully, but these errors were encountered: