Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

NPE in instance status #491

Closed
jvalkeal opened this issue Mar 8, 2022 · 0 comments · Fixed by #492
Closed

NPE in instance status #491

jvalkeal opened this issue Mar 8, 2022 · 0 comments · Fixed by #492
Milestone

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Mar 8, 2022

In acc tests we see errors in a skipper logs:

java.lang.NullPointerException: null
        at java.base/java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source) ~[na:na]
        at java.base/java.util.concurrent.ConcurrentHashMap.put(Unknown Source) ~[na:na]
        at org.springframework.cloud.deployer.spi.kubernetes.KubernetesAppInstanceStatus.getAttributes(KubernetesAppInstanceStatus.java:139) ~[spring-cloud-deployer-kubernetes-2.8.0-SN
APSHOT.jar:2.8.0-SNAPSHOT]
        at org.springframework.cloud.skipper.server.deployer.DefaultReleaseManager.lambda$copyStatus$15(DefaultReleaseManager.java:578) ~[spring-cloud-skipper-server-core-2.9.0-SNAPSHO
T.jar:2.9.0-SNAPSHOT]

https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/blob/5a0c80adc82b9b665a9bfbd385e1ceac109331d1/src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppInstanceStatus.java#L139

It was changed fromHashMap to ConcurrentHashMap which doesn't allow null values.

@jvalkeal jvalkeal added this to the 2.8.0-M2 milestone Mar 8, 2022
onobc added a commit to onobc/spring-cloud-deployer-kubernetes that referenced this issue Mar 8, 2022
@onobc onobc closed this as completed in #492 Mar 8, 2022
onobc added a commit that referenced this issue Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant