Skip to content

Config Server: S3 integration should consume the same files as in Git intergation #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bryksin opened this issue Mar 11, 2021 · 0 comments · Fixed by #2780
Closed

Config Server: S3 integration should consume the same files as in Git intergation #1829

Bryksin opened this issue Mar 11, 2021 · 0 comments · Fixed by #2780

Comments

@Bryksin
Copy link

Bryksin commented Mar 11, 2021

Hi

Recently our internal git failed what effected our production as the Config Server was not able to checkout configs for all services.
To resolve it we decided to use S3 bucket as a fallback, however, after I set up the bucket and upload our config files from Git I noticed that it doesn't work... with a bit of reading through the documentation I found that S3 bucket require to have file names in a specific format: <service_name>-<profile>.yml
However, in our Git we have a single file with just the name of the service and multiple profiles inside what perfectly supported by YAML and the config service is able to extract a specific profile from such file.

Additionally, our service name and profile names include dashes eg:
Service name: notification-service.yml
Profile: qa54-nsapce25-docker which refer to:
qa65 - QA environment
nsapce25 - specific nsapce within EKS / Kubernetes
docker - means service run from docker, and not from local code

so having a file with a name like "notification-service-qa54-nsapce25-docker.yml" doesn't work in S3 either

kkurczewski added a commit to kkurczewski/spring-cloud-config that referenced this issue Mar 5, 2025
@ryanjbaxter ryanjbaxter added this to the 4.3.0-M3 milestone Mar 5, 2025
ryanjbaxter pushed a commit that referenced this issue Mar 5, 2025
* Make S3 and Git backends more compatible

Fixes #1829

Signed-off-by: Krzysztof Kurczewski <[email protected]>

* Add docs

Signed-off-by: kkurczewski <[email protected]>

* Use relative link

Signed-off-by: kkurczewski <[email protected]>

* Add explicit note about new flag for S3 backend

Signed-off-by: kkurczewski <[email protected]>

---------

Signed-off-by: Krzysztof Kurczewski <[email protected]>
Signed-off-by: kkurczewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants