-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support new delimiters in spring.config.location #1904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new delimiters in spring.config.location #1904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could delete the hooks from test repo, but LGTM
If back compatibility is an issue then you could pick the delimiter based on the presence of the |
I think we are fine with not being compatible with releases prior to Boot 2.4.7. |
Codecov Report
@@ Coverage Diff @@
## main #1904 +/- ##
============================================
+ Coverage 78.13% 78.16% +0.03%
- Complexity 1325 1329 +4
============================================
Files 167 167
Lines 4894 4901 +7
Branches 657 657
============================================
+ Hits 3824 3831 +7
Misses 807 807
Partials 263 263
Continue to review full report at Codecov.
|
Fixes #1895
Requires Boot 2.4.7