fix(bashScript): download correct vault zip for arm64 processor #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_vault.sh just download and unzip binary vault for amd64, which cannot be executed on arm64 architecture processors. Add architecture checking in bash script to support this. Signed-off-by: maaaace <[email protected]>
|
@maaaace Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@maaaace Thank you for signing the Contributor License Agreement! |
mp911de
pushed a commit
that referenced
this pull request
May 19, 2020
install_vault.sh just download and unzip binary vault for amd64, which cannot be executed on arm64 architecture processors. Add architecture checking in bash script to support this. Signed-off-by: maaaace <[email protected]> Original pull request: gh-402.
mp911de
pushed a commit
to spring-projects/spring-vault
that referenced
this pull request
May 19, 2020
install_vault.sh just download and unzip binary vault for amd64, which cannot be executed on arm64 architecture processors. Add architecture checking in bash script to support this. Signed-off-by: maaaace <[email protected]> Original pull request: spring-cloud/spring-cloud-vault#402. Closes gh-562.
mp911de
pushed a commit
to spring-projects/spring-vault
that referenced
this pull request
May 19, 2020
install_vault.sh just download and unzip binary vault for amd64, which cannot be executed on arm64 architecture processors. Add architecture checking in bash script to support this. Signed-off-by: maaaace <[email protected]> Original pull request: spring-cloud/spring-cloud-vault#402. Closes gh-562.
|
Thanks a lot. That's merged and backported, also to Spring Vault now. |
spencergibb
pushed a commit
that referenced
this pull request
Sep 14, 2023
install_vault.sh just download and unzip binary vault for amd64, which cannot be executed on arm64 architecture processors. Add architecture checking in bash script to support this. Signed-off-by: maaaace <[email protected]> Original pull request: gh-402.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_vault.sh just download and unzip binary vault for amd64, which cannot be executed
on arm64 architecture processors. Add architecture checking in bash script to support this.
Signed-off-by: maaaace [email protected]