-
Notifications
You must be signed in to change notification settings - Fork 106
Spring Cloud AWS does not support SB 3 yet #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
artembilan
added a commit
to artembilan/stream-applications
that referenced
this issue
Oct 19, 2022
Fixes spring-cloud#368 * Upgrade to `spring-cloud-aws-2.4.2`; fix respective package changes * Remove `AutoConfigurationExclusionEnvironmentPostProcessor` since classes in the SC-AWS are not considered as auto-configuration anymore. Instead, add an explicit `@Import` into `AmazonS3Configuration`. Not sure, though, why it was excluded before at all * Fix `MetadataStoreAutoConfigurationTests` with the current state of code. Looks like before it was designed for auto-configuration based on classpath content * Re-enable other AWS S3 tests This fix has helped to spot a bug in Spring Integration Testing framework: spring-projects/spring-integration@e2d8eeb
onobc
added a commit
to artembilan/stream-applications
that referenced
this issue
Oct 20, 2022
onobc
added a commit
that referenced
this issue
Oct 20, 2022
Fixes #368 * Upgrade to `spring-cloud-aws-2.4.2`; fix respective package changes * Remove `AutoConfigurationExclusionEnvironmentPostProcessor` since classes in the SC-AWS are not considered as auto-configuration anymore. Instead, add an explicit `@Import` into `AmazonS3Configuration`. Not sure, though, why it was excluded before at all * Fix `MetadataStoreAutoConfigurationTests` with the current state of code. Looks like before it was designed for auto-configuration based on classpath content * Re-enable other AWS S3 tests This fix has helped to spot a bug in Spring Integration Testing framework: spring-projects/spring-integration@e2d8eeb Co-authored-by: Chris Bono <[email protected]>
artembilan
added a commit
to spring-cloud/spring-functions-catalog
that referenced
this issue
Nov 22, 2023
Fixes spring-cloud/stream-applications#368 * Upgrade to `spring-cloud-aws-2.4.2`; fix respective package changes * Remove `AutoConfigurationExclusionEnvironmentPostProcessor` since classes in the SC-AWS are not considered as auto-configuration anymore. Instead, add an explicit `@Import` into `AmazonS3Configuration`. Not sure, though, why it was excluded before at all * Fix `MetadataStoreAutoConfigurationTests` with the current state of code. Looks like before it was designed for auto-configuration based on classpath content * Re-enable other AWS S3 tests This fix has helped to spot a bug in Spring Integration Testing framework: spring-projects/spring-integration@e2d8eeb Co-authored-by: Chris Bono <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All S3 related functions/apps rely on Spring Cloud AWS and the corresponding tests have been disabled.
Possible temp solution
The immediate failure is "Unable to exclude auto-config because its not auto-config" at app startup. This is due to the fact that SB3 requires
AutoConfiguration.imports
rather thanspring.factories
. One idea is to provide the newerAutoConfiguration.imports
file to the Spring Cloud AWS repo which would allow both SB2.x and SB3.x to recognize the ACs. Another idea is hosting those files here in stream-applications repo and not even have to modify the Spring Cloud AWS repo. We should try that first.The text was updated successfully, but these errors were encountered: