Skip to content

ScriptProcessor failures #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
onobc opened this issue Oct 18, 2022 · 0 comments · Fixed by #419
Closed

ScriptProcessor failures #370

onobc opened this issue Oct 18, 2022 · 0 comments · Fixed by #419
Assignees
@artembilan
Labels
theme: boot30
Milestone
4.0.0

Comments

@onobc
Copy link
Collaborator

onobc commented Oct 18, 2022

ScriptProcessor is currently broken for Javascript and Ruby

JavaScript

SpringIntegration added back support for JS via the GraalVM polyglot support.

  • looks like we have to install GraalVM JS locally in order to run tests?

Ruby

Ruby fails as we need to add-opens to the engine

Tests have been @Disabled
@artembilan artembilan mentioned this issue Oct 18, 2022
Closed
artembilan added a commit to artembilan/stream-applications that referenced this issue Jan 10, 2023
@artembilan
spring-cloudGH-370: Enable ScriptProcessor tests back
487bc09 
Fixes spring-cloud#370

* Update dependencies for `script-processor`
* Add `maven-surefire-plugin` to `script-processor` POM
and specify `--add-opens` for Ruby requirements
* Mark all JavaScript tests with `@EnabledIfSystemProperty`
against `org.graalvm.language.js.home` which is available only
if GraalVM with `js` component enabled
* Fix `NewlineAtEndOfFile` rule for Checkstyle since on Windows
the line end is `crlf`
* Add `components: 'js'` to GraalVM installation steps for all the GH action scripts
@artembilan artembilan mentioned this issue Jan 10, 2023
Merged
@artembilan artembilan added this to the 2022.0.0 milestone Jan 10, 2023
artembilan added a commit to artembilan/stream-applications that referenced this issue Jan 11, 2023
@artembilan
spring-cloudGH-370: Enable ScriptProcessor tests back
bf270c1 
Fixes spring-cloud#370

* Update dependencies for `script-processor`
* Add `maven-surefire-plugin` to `script-processor` POM
and specify `--add-opens` for Ruby requirements
* Mark all JavaScript tests with `@EnabledIfSystemProperty`
against `org.graalvm.language.js.home` which is available only
if GraalVM with `js` component enabled
* Fix `NewlineAtEndOfFile` rule for Checkstyle since on Windows
the line end is `crlf`
* Add `components: 'js'` to GraalVM installation steps for all the GH action scripts
onobc pushed a commit that referenced this issue Jan 11, 2023
@artembilan
GH-370: Enable ScriptProcessor tests back (#419)
52e0719 
* GH-370: Enable ScriptProcessor tests back

Fixes #370

* Update dependencies for `script-processor`
* Add `maven-surefire-plugin` to `script-processor` POM
and specify `--add-opens` for Ruby requirements
* Mark all JavaScript tests with `@EnabledIfSystemProperty`
against `org.graalvm.language.js.home` which is available only
if GraalVM with `js` component enabled
* Fix `NewlineAtEndOfFile` rule for Checkstyle since on Windows
the line end is `crlf`
* Add `components: 'js'` to GraalVM installation steps for all the GH action scripts

* * Add dependencies for `graal-sdk` and `org.graalvm.js`
to make JavaScript working on a plain JVM
@onobc onobc modified the milestones: 2022.0.0, 4.0.0 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
theme: boot30
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

GH-370: Enable ScriptProcessor tests back artembilan/stream-applications
2 participants
@artembilan @onobc