Skip to content

Update apps metadata to include nested config props #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onobc opened this issue Jun 12, 2023 · 1 comment · Fixed by #476
Closed

Update apps metadata to include nested config props #475

onobc opened this issue Jun 12, 2023 · 1 comment · Fixed by #476
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@onobc
Copy link
Collaborator

onobc commented Jun 12, 2023

We recently discovered that some apps use config props that in turn has nested config props (eg KafkaProperties$ProducerProperties in kafka-source).

The following apps need updating (there may be others as well):

  • sftp-sink

  • ftp-source

  • ???

            I wonder if there are other apps that use config props that have nesting and we just did not notice until this one?
    

Originally posted by @onobc in #474 (comment)

@onobc onobc added this to the 4.0.0-RC1 milestone Jun 12, 2023
@artembilan
Copy link
Member

The following apps need updating (there may be others as well):

Sorry, that was not I meant.
Those apps have props like this:

configuration-properties.classes=org.springframework.cloud.fn.supplier.sftp.SftpSupplierProperties, \
  org.springframework.cloud.fn.supplier.sftp.SftpSupplierProperties$Factory, \
  org.springframework.cloud.fn.supplier.sftp.SftpSupplierProperties$SortSpec, \
  org.springframework.cloud.fn.common.file.FileConsumerProperties, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties$Gemfire, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties$Redis, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties$DynamoDb, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties$Jdbc, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties$Zookeeper, \
  org.springframework.cloud.fn.common.metadata.store.MetadataStoreProperties$Mongo \

With that I mean the place where I took an idea how that can be provided.
And that was a pointer that we have apps with nested props.

I'll take this and will try to take care about missed parts if that.

@artembilan artembilan self-assigned this Jun 12, 2023
@artembilan artembilan added the enhancement New feature or request label Jun 12, 2023
artembilan added a commit to artembilan/stream-applications that referenced this issue Jun 12, 2023
Fixes spring-cloud#475

* Fix JDBC props for limited listed number of them
onobc pushed a commit that referenced this issue Jun 13, 2023
Fixes #475

* Fix JDBC props for limited listed number of them
artembilan added a commit to spring-cloud/spring-functions-catalog that referenced this issue Nov 22, 2023
Fixes spring-cloud/stream-applications#475

* Fix JDBC props for limited listed number of them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants