Make allow negative keep alive value with OllamaEmbeddingModel #2256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In issue #2197, it was identified that the keep-alive option for embedding models did not allow negative values. This limitation restricted certain configurations as described in the documentation.
Modification:
Updated the regex to enable the keep-alive option for embedding models to accept negative values.
Result:
Users can now configure negative values for the keep-alive option in embedding models, addressing the issue mentioned.
This resolves #2197.
Verification:
When set to 1m:
The keep-alive duration is correctly set to 1 minute.
Logs:
When set to -1m:
The keep-alive duration is correctly interpreted as infinite, as documented.
Logs: