Async @RabbitListener does not handle AmqpRejectAndDontRequeueException

[peterlgh7]

Bug report

spring-amqp version: 2.1.7-RELEASE

The documentation for asynchronous @RabbitListener states:

If the async result is completed with an AmqpRejectAndDontRequeueException, the message will not be requeued.

The following example listener instead requeues the message and loops indefinitely:

import org.springframework.amqp.rabbit.annotation.RabbitListener;
import org.springframework.stereotype.Component;
import org.springframework.util.concurrent.ListenableFuture;
import org.springframework.util.concurrent.SettableListenableFuture;

@Component
public class Listener {

  @RabbitListener(queues = "example")
  public ListenableFuture<Void> receive(User user) {
    System.out.println(user);
    SettableListenableFuture<Void> future = new SettableListenableFuture<>();
    future.setException(new RuntimeException());
    return future;
  }
}

The problem seems to lie on the AbstractAdaptableMessageListener. The requeue flag is true regardless of the exception type:

spring-amqp/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/AbstractAdaptableMessageListener.java

Lines 380 to 388 in 8336d4e

	private void asyncFailure(Message request, Channel channel, Throwable t) {
	this.logger.error("Future or Mono was completed with an exception for " + request, t);
	try {
	channel.basicNack(request.getMessageProperties().getDeliveryTag(), false, true);
	}
	catch (IOException e) {
	this.logger.error("Failed to nack message", e);
	}
	}

Moreover, not an issue for me now, but the documentation also states:

By default, the message will be requeued, unless the container’s defaultRequeueRejected property is set to false

And from the snippet above, it doesn't seem to be true either.

[peterlgh7]

That was a really quick fix! I was actually interested in contributing here. In the future, should I clearly state it in the bug report?

[artembilan]

Right, typically we are very open for Contribution, but right now it is a rush to make as much fixes as possible for upcoming release on Monday. Thank you for proposal anyway: there are still some issues you can pick up for Contribution!

[peterlgh7]

Ok, I will take a look at those soon. This one just looked like such an easy one for my first contribution :) ...

[garyrussell]

In the future, should I clearly state it in the bug report?

Thanks; yes, in general, it's best to note that you intend to contribute a fix.

As Artem said, though, this time we are so close to the next release I picked it up right away.