Memory Leak in RabbitTemplate when using custom correlationId

[harald-raffelt]

Affects Version(s): \2.2.3.RELEASE
Since https://jira.spring.io/browse/AMQP-779

When using custom correlationId there is a memory leak in the following line:

spring-amqp/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/core/RabbitTemplate.java

Line 1967 in 838b88a

this.replyHolder.remove(messageTag);

The field replyHolder of class RabbitTemplate is always cleaned up using the messageTag variable in the end of method doSendAndReceiveAsListener.
Even if the correlatrionId is used to put a pending reply in that replyHolder map.

---

In my humble opinion the method should ony use one of the local variables messageTag and correlationId.

[garyrussell]

Good catch; thanks.

This has been there a long time; I guess most people don't use a custom correlation id.