GH-1194: Fix cache limit with Pub Confirms channel #1196
Conversation
Resolves spring-projects#1194 Deferred channel closes were unconditionally returned to the cache. Move the cache size check etc to `doReturnToCache`. **cherry-pick to 2.2.x, 2.1.x**
|
... and cherry-picked to |
|
Can I test this now? and which version should I use? |
|
(Boot 2.1.x) 2.1.15.BUILD-SNAPSHOT (spring-amqp and spring-rabbit) or 2.2.7.BUILD-SNAPSHOT (Boot 2.2.x). |
|
Thank you. |
|
@garyrussell I verified with (Boot 2.1.x) 2.1.15.BUILD-SNAPSHOT, but I am still seeing the same issue. It pulled 2.1.14.RELEASE version of spring-amqp and spring-rabbit. |
|
You need to override those jars to 2.1.15.BUILD-SNAPSHOT too. Boot usually doesn't pull in snapshot dependencies until near its next release. |
|
Now it worked as expected. When can we expect 2.1.15.RELEASE? |
|
It would normally be released a short time before Boot 2.1.15 which is currently scheduled for June 25. But I can look into doing it before then if you need it earlier (it will work with Boot 2.1.14). |
|
@garyrussell We are planning to use this feature before June 25th. If you can do that(it will work with Boot 2.1.14), it would be great. |
|
OK; I've moved it to next Wednesday - is that enough for you? |
|
Yes, that will work. Thank you. |
|
@srudrar 2.1.15 and 2.2.7 including this fix are in the Spring repo and Maven Central. |
|
Thank you |
Resolves #1194
Deferred channel closes were unconditionally returned to the cache.
Move the cache size check etc to
doReturnToCache.cherry-pick to 2.2.x, 2.1.x