Update AmqpAppender.java #1225
Closed
Update AmqpAppender.java #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if stopped is true, this.manager.stop(timeout, timeUnit) is not call, and the rabbit connecting not destory
|
@yhyecho Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
This doesn't look like a trivial change and it probably needs some simple test-case. Please, consider to sign the CLA and try to provide the test cover this behavior. Thanks |
|
Thanks for pointing this out and submitting a PR, but we are not allowed to merge your code without you signing the CLA; I will fix this problem in a similar manner. |
garyrussell
added a commit
to garyrussell/spring-amqp
that referenced
this pull request
Jul 22, 2020
Replaces spring-projects#1225 `manager.stop()` was never called to destroy the connection factory, preventing JVM exit. Also protect for re-connecting after stop (both appenders). Tested with a Spring Boot application. **cherry-pick to 2.2.x, 2.1.x, 1.7.x**
artembilan
pushed a commit
that referenced
this pull request
Jul 22, 2020
Replaces #1225 `manager.stop()` was never called to destroy the connection factory, preventing JVM exit. Also protect for re-connecting after stop (both appenders). Tested with a Spring Boot application. **cherry-pick to 2.2.x, 2.1.x, 1.7.x**
artembilan
pushed a commit
that referenced
this pull request
Jul 22, 2020
Replaces #1225 `manager.stop()` was never called to destroy the connection factory, preventing JVM exit. Also protect for re-connecting after stop (both appenders). Tested with a Spring Boot application. **cherry-pick to 2.2.x, 2.1.x, 1.7.x**
artembilan
pushed a commit
that referenced
this pull request
Jul 22, 2020
Replaces #1225 `manager.stop()` was never called to destroy the connection factory, preventing JVM exit. Also protect for re-connecting after stop (both appenders). Tested with a Spring Boot application. **cherry-pick to 2.2.x, 2.1.x, 1.7.x** # Conflicts: # spring-rabbit/src/main/java/org/springframework/amqp/rabbit/logback/AmqpAppender.java
garyrussell
added a commit
that referenced
this pull request
Jul 23, 2020
Replaces #1225 `manager.stop()` was never called to destroy the connection factory, preventing JVM exit. Also protect for re-connecting after stop (both appenders). Tested with a Spring Boot application. **cherry-pick to 2.2.x, 2.1.x, 1.7.x**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if stopped is true, this.manager.stop(timeout, timeUnit) is not call, and the rabbit connecting not destory