Move AOT hints to main module #1446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the codebase and, more interestingly, specifically by the various JDBC-persisting repository implementations. This follows up on spring-projects#1380
spring-projects-issues
added
the
status: waiting-for-triage
kwonglau
reviewed
Nov 15, 2023
| TypeReference.of(SimpleGrantedAuthority.class), TypeReference.of(OidcIdToken.class), | ||
| TypeReference.of(AbstractOAuth2Token.class), TypeReference.of(OidcUserInfo.class), | ||
| TypeReference.of(OAuth2AuthorizationRequest.class), TypeReference.of(AuthorizationGrantType.class), | ||
| TypeReference.of(OAuth2AuthorizationResponseType.class), TypeReference.of(OAuth2TokenFormat.class)), |
There was a problem hiding this comment.
could we also add
TypeReference.of(DefaultSavedRequest.Builder.class) here
kwonglau
reviewed
Nov 15, 2023
| this.reflectionHintsRegistrar.registerReflectionHints(hints.reflection(), | ||
| Class.forName("org.springframework.security.oauth2.server.authorization.jackson2.OAuth2TokenFormatMixin")); | ||
| } catch (ClassNotFoundException ex) { | ||
| this.reflectionHintsRegistrar.registerReflectionHints(hints.reflection(), Class.forName( |
There was a problem hiding this comment.
could we also add
this.reflectionHintsRegistrar.registerReflectionHints(hints.reflection(), Class.forName("org.springframework.security.web.jackson2.DefaultSavedRequestMixin"));
here
jgrandja
changed the title
jgrandja
added
type: enhancement
|
Thanks for the PR @joshlong ! This is now merged with a follow-up polish commit. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces AOT hints for types and resources used across the codebase and, more interestingly, specifically by the various JDBC-persisting repository implementations. This follows up on #1380