Add ability to disable an endpoint #1924
Conversation
Issue spring-projectsgh-1882 Signed-off-by: Tommy Tsang <[email protected]>
…onServerConfigurer and OAuth2ClientAuthenticationConfigurer Issue spring-projectsgh-1882 Signed-off-by: Tommy Tsang <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -170,6 +166,11 @@ public OAuth2AuthorizationServerConfigurer clientAuthentication( | |||
| return this; | |||
| } | |||
|
|
|||
| public OAuth2AuthorizationServerConfigurer disableClientAuthentication() { | |||
There was a problem hiding this comment.
As mentioned in this comment:
I also think we should come up with a solution that allows other endpoints to be disabled if needed. I don't think a "flag" setting on all the configurers makes sense.
I consider disableClientAuthentication(), disableAuthorizationServerMetadataEndpoint(), disableAuthorizationEndpoint(), etc. to be a similar solution as proposed in the previous PR but with an "explicit" flag through the introduction of the disable** public methods.
As mentioned, this is still not ideal as it introduces too many new public API's and I would prefer a solution that is more isolated.
I have been thinking about this for a while and may have a solution to address this but unfortunately I don't have the time at the moment as I have a couple of other features I've been working on that are priority for the upcoming release.
I'm going to close this PR but if you have other ideas please comment in gh-1882 before submitting another PR.
jgrandja
added
status: declined
Add ability to disable endpoint
Related gh-1882