Bump spring-boot-starter-parent from 3.3.5 to 3.4.0
#161
Conversation
|
Because we (as in Neo4j) are planning to release the Neo4j 5 LTS version in a few weeks, I think it is good to bump the id function to elementId (finally). We sticked with the -for Neo4j 5- deprecated |
| when(idDescription.asIdExpression(anyString())).thenReturn(Functions.id(Cypher.anyNode())); | ||
| when(idDescription.asIdExpression(anyString())).thenReturn(Cypher.anyNode().elementId()); |
There was a problem hiding this comment.
Here, I had to find an alternative to Functions.id because it was no longer accessible with the Neo4J version that Spring Boot is now pulling, but I have to admit I didn't go after all the details.
Is this related to what you just mentioned, @meistermeier? Anything you would do differently?
There was a problem hiding this comment.
Yes, it is from a product perspective very different. The elementId is a complete new (internal) field introduced in Neo4j 5 as a replacement for the id.
From a dependency perspective the update might have pulled in new major version of the Cypher DSL (sorry that I have missed this) where we tried to unify the entry point to Cypher.... for operations and functions.
The only difference, if users don't specify the right Neo4j dialect for the CypherDSL (Neo4j_5) is that the elementId function will create a fallback to toString(id(node)) (no index) instead of elementId(node) (index support) in the resulting Cypher statement.
It's ok with me because a) we should really switch to elementId and b) it is documented in the CypherDSL. (https://neo4j.github.io/cypher-dsl/2024.2.0/#dialect-support)
There was a problem hiding this comment.
Thanks for the explanation, @meistermeier! I wait then for your formal approval before merging these changes 🙂
No description provided.