Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions of properties that no longer require Flyway Teams #44460

Closed
wants to merge 2 commits into from

Conversation

bekoenig
Copy link
Contributor

@bekoenig bekoenig commented Feb 27, 2025

Since flyway v10 most of teams features are available for community too (see here). I checked the documentation and removed obsoleted hints in java documentation.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 27, 2025
@wilkinsona
Copy link
Member

Thanks for the PR. Please sign your commit so that the DCO check passes.

To verify that these properties can be configured with the community edition, can you please update FlywayAutoConfigurationTests as well? We're missing tests for detect-encoding and ignore-migration-patterns.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Feb 27, 2025
@nosan
Copy link
Contributor

nosan commented Feb 27, 2025

Hi @bekoenig,

To ensure your commit passes the DCO check, you can follow the instructions provided in this link

Also, you can find useful information here as well: Hello DCO, Goodbye CLA

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 27, 2025
@wilkinsona wilkinsona changed the title Removed obsoleted hints for Flyway Teams features Update descriptions of properties that no longer require Flyway Teams Feb 27, 2025
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 27, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Feb 27, 2025
@bekoenig
Copy link
Contributor Author

Thanks @wilkinsona and @nosan for your explanation. The DCO check is now successful.

@mhalbritter
Copy link
Contributor

Thanks @bekoenig !

@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.10 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants