Revise OffsetScrollPosition to use zero-based indexes
#3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2024
mp911de
reviewed
Apr 3, 2024
| @@ -141,7 +149,7 @@ public OffsetScrollPosition apply(int offset) { | |||
| throw new IndexOutOfBoundsException(offset); | |||
| } | |||
|
|
|||
| return of(startOffset + offset + 1); | |||
| return of(startOffset + offset); | |||
There was a problem hiding this comment.
How about introducing a factory method for OffsetPositionFunction on OffsetScrollPosition to hide away offset.isInitial() ? 0 : offset.getOffset() as in OffsetScrollPosition.positionFunction(offset.isInitial() ? 0 : offset.getOffset()) on the calling code site?
mp911de
changed the title
OffsetScrollPosition to use zero-based indexes
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-commons
that referenced
this pull request
May 20, 2024
…crolling Position. Closes spring-projects#3070 Original pull request: spring-projects#3072
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-commons
that referenced
this pull request
May 20, 2024
Introduce method to obtain a position function from OffsetScrollPosition. Tweak documentation wording. See spring-projects#3070 Original pull request: spring-projects#3072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.