Skip to content

Add matched_queries field to SearchHit. #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mdgilene
Copy link
Contributor

@mdgilene mdgilene commented Mar 5, 2021

Closes #1514

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@mdgilene mdgilene changed the title Add matched_queries fied to SearchHit. Add matched_queries field to SearchHit. Mar 5, 2021
@mdgilene mdgilene force-pushed the feature-DATAES-979-matched_queries branch from 6f0d8b1 to 7cf90ae Compare March 5, 2021 19:35
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 5, 2021
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, just have been looking at this PR and seen that I have not submitted the review, although I did the review when you submitted the PR. I could have sworn I had hit the submit button.

Two minor places: Spring Data baseline is Java 8, so there are two places that need to be changed.

@mdgilene
Copy link
Contributor Author

Ahh Java 8 vs 9 didn't even cross my mind. Fixed!

@mdgilene mdgilene requested a review from sothawo March 10, 2021 23:13
@sothawo sothawo merged commit 4dc8b25 into spring-projects:master Mar 11, 2021
@sothawo
Copy link
Collaborator

sothawo commented Mar 11, 2021

Thanks again for this PR.

@mdgilene mdgilene deleted the feature-DATAES-979-matched_queries branch March 11, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add matched_queries field in SearchHit [DATAES-979]
3 participants