Change mapping of connectionRequestTimeout to ConnPool leaseTimeout #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thank you very much you for finding and fixing this. |
sothawo
reviewed
Sep 10, 2021
Comment on lines
114
to
+116
| if (!timeout.isNegative()) { | ||
| requestConfigBuilder.setSocketTimeout(Math.toIntExact(timeout.toMillis())); | ||
| requestConfigBuilder.setConnectionRequestTimeout(Math.toIntExact(connectTimeout.toMillis())); |
There was a problem hiding this comment.
just at a second look I saw that you moved the line into the if for the socketTimeout, but still using the configured value for the connectTimeout. Shouldn't do PRs in the morning before work. I'll fix that.
sothawo
pushed a commit
that referenced
this pull request
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the RestClients.create() method sets the underlying RequestConfig connectTimeout and connectionRequestTimeout properties to the value of the ClientConfiguration connectTimeout property.
The connectionRequestTimeout is used as the leaseTimeout parameter when calling the AbstractNIOConnPool lease method, which can lead to a "TimeoutException: Connection lease request time out" on an establised connection.
The correct behavior is to use the sockerTimeout property for the leastTimeout parameter.