Migrate to JSpecify annotations for nullability constraints. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
requested changes
Feb 18, 2025
pom.xml
Outdated
| @@ -45,6 +45,11 @@ | |||
| <version>${querydsl}</version> | |||
| <optional>true</optional> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
This isn't required, JSpecify is a transitive dependency of Spring Framework.
| @@ -195,6 +195,7 @@ public <T> T update(Object id, T objectToUpdate) { | |||
| Assert.notNull(objectToUpdate, "Object to be updated must not be null"); | |||
|
|
|||
| String keyspace = resolveKeySpace(objectToUpdate.getClass()); | |||
| Assert.notNull(keyspace, "Keyspace must not be null"); | |||
There was a problem hiding this comment.
good catch - added that one before the null check in resolveKeySpace - same goes for others
|
|
||
| Assert.notNull(id, "Id for object to be deleted must not be null"); | ||
| Assert.notNull(type, "Type to delete must not be null"); | ||
|
|
||
| String keyspace = resolveKeySpace(type); | ||
| Assert.notNull(keyspace, "Keyspace must not be null"); |
| @@ -233,6 +235,7 @@ public <T> Optional<T> findById(Object id, Class<T> type) { | |||
| Assert.notNull(type, "Type to fetch must not be null"); | |||
|
|
|||
| String keyspace = resolveKeySpace(type); | |||
| Assert.notNull(keyspace, "Keyspace must not be null"); | |||
| @@ -78,12 +79,13 @@ private List<?> sortAndFilterMatchingRange(Iterable<?> source, @Nullable Predica | |||
| return filterMatchingRange(tmp, criteria, offset, rows); | |||
| } | |||
|
|
|||
| private static <S> List<S> filterMatchingRange(List<S> source, @Nullable Predicate criteria, long offset, int rows) { | |||
| @Contract("!null, _, _, _ -> !null") | |||
There was a problem hiding this comment.
Hum, the return is never null and source cannot be null. You sure about this annotation?
There was a problem hiding this comment.
never null regardless of input - I don't mind dropping it.
| @@ -145,7 +145,7 @@ public void registerBeansForRoot(BeanDefinitionRegistry registry, RepositoryConf | |||
|
|
|||
| AbstractBeanDefinition beanDefinition = getDefaultKeyValueTemplateBeanDefinition(configurationSource); | |||
|
|
|||
| if (beanDefinition != null) { | |||
| if (beanDefinition != null && configurationSource.getSource() != null) { | |||
| registerIfNotAlreadyRegistered(() -> beanDefinition, registry, keyValueTemplateName.get(), | |||
There was a problem hiding this comment.
Looks like a missing @Nullable annotation for source in Commons.
There was a problem hiding this comment.
maybe... care to check in commons.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.