Skip to content

Introduce factory methods to configure LettuceConnectionFactory from RedisURI #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Jul 7, 2021 · 0 comments
Closed

Introduce factory methods to configure LettuceConnectionFactory from RedisURI #2116

mp911de opened this issue Jul 7, 2021 · 0 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
2.5.3 (2021.0.3)

Comments

@mp911de
Copy link
Member

mp911de commented Jul 7, 2021

Lettuce supports multiple URI schemes (redis-sentinel://, redis-socket://, …). It would make sense to provide a factory method on LettuceConnectionFactory that takes, RedisURI or URI and returns a properly configured RedisConfiguration object for easier configuration of the connection factory.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 7, 2021
@snicoll snicoll mentioned this issue Jul 7, 2021
Closed
@onobc onobc mentioned this issue Jul 12, 2021
Closed
4 tasks
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 12, 2021
@mp911de mp911de added this to the 2.5.3 (2021.0.3) milestone Jul 13, 2021
mp911de pushed a commit that referenced this issue Jul 13, 2021
@onobc @mp911de
Add factory method to LettuceConnectionFactory to create RedisConfigu…
232410d 
…ration from RedisURI.

Closes #2116.
Original pull request: #2117.
mp911de added a commit that referenced this issue Jul 13, 2021
@mp911de
Polishing.
3448f3b 
Reorder methods. Remove unnecessary null guards. Introduce hashCode/equals methods to RedisConfiguration implementations. Refactor tests. Let LettuceClientConfiguration.builder apply settings from RedisURI. Introduce SentinelMasterId to implement equals method.

See #2116.
Original pull request: #2117.
mp911de added a commit that referenced this issue Jul 13, 2021
@mp911de
Polishing.
3286d57 
Reorder methods. Remove unnecessary null guards. Introduce hashCode/equals methods to RedisConfiguration implementations. Refactor tests. Let LettuceClientConfiguration.builder apply settings from RedisURI. Introduce SentinelMasterId to implement equals method.

See #2116.
Original pull request: #2117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5.3 (2021.0.3)
2 participants
@mp911de @spring-projects-issues