Fix result sorting using Redis repository query methods #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now correctly apply sorting when calling a repository query method with a Sort parameter or when defining the sort order as part of the method name.
mp911de
changed the title
| ---- | ||
| interface PersonRepository extends RedisRepository<Person, String> { | ||
|
|
||
| List<Person> findByFirstnameSortByAgeDesc(String firstname); <1> |
There was a problem hiding this comment.
Shouldn't this be OrderBy instead of SortBy? The former is what the unit test uses.
There was a problem hiding this comment.
Good catch. This snippet originates from the MongoDB documentation that needs to be updated as well. Also, we should document the OrderBy keyword in the table of supported keywords.
christophstrobl
pushed a commit
that referenced
this pull request
Jun 18, 2021
We now correctly apply sorting when calling a repository query method with a Sort parameter or when defining the sort order as part of the method name. Original Pull Request: #2087
christophstrobl
added a commit
that referenced
this pull request
Jun 18, 2021
Fix sorting query part that should be 'orderBy'. Original Pull Request: #2087
christophstrobl
added a commit
that referenced
this pull request
Jun 18, 2021
Fix sorting query part that should be 'orderBy'. Original Pull Request: #2087
|
merged to 2.5.x and forward ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now correctly apply sorting when calling a repository query method with a Sort parameter or when defining the sort order as part of the method name.
Closes #2080