Skip to content

Refine Topic creation for ChannelTopic and PatternTopic #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dev-jonghoonpark
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark commented Apr 16, 2025

related doc: https://docs.spring.io/spring-data/redis/reference/redis/pubsub.html

Previously, the document explained that listener topics can be set using a pattern but did not mention the PatternTopic class, so this information has been added.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 16, 2025
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 17, 2025
@mp911de mp911de added this to the 3.5 RC1 (2025.0.0) milestone Apr 17, 2025
@mp911de mp911de self-assigned this Apr 17, 2025
@mp911de mp911de changed the title Added a mention of the PatternTopic class to the pubsub.adoc document Refine Topic creation for ChannelTopic and PatternTopic Apr 17, 2025
@mp911de
Copy link
Member

mp911de commented Apr 17, 2025

Thanks for reaching out. It makes sense to introduce factory methods on the Topic interface to construct ChannelTopic and PatternTopic types.

@mp911de mp911de closed this in 0de3af0 Apr 17, 2025
mp911de added a commit that referenced this pull request Apr 17, 2025
We now expose factory methods to construct ChannelTopic and PatternTopic from the Topic interface.

See #3131
mp911de pushed a commit that referenced this pull request Apr 17, 2025
mp911de added a commit that referenced this pull request Apr 17, 2025
We now expose factory methods to construct ChannelTopic and PatternTopic from the Topic interface.

See #3131
@mp911de
Copy link
Member

mp911de commented Apr 17, 2025

Thank you for your contribution. That's merged and polished now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants