You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're writing our own dialect for the Spring Data JDBC aiming to support YDB. And we hit the problem: ydb-platform/ydb-java-dialects#173
The summary is that we seems to need to extend the QueryLookupStrategy. That is not a big deal, since it is public, however, we want to retian the logic of the RowMapper selection mechanism, as well as resolution of the StringBased/PartTree queries. This logic is outlined in the JdbcQueryLookupStrategy, which is apparently not public.
Proposal: Since the QueryLookupStrategy is constructed in JdbcRepositoryFactory, therefore it actually is intended to be overloaded, can we make the JdbcQueryLookupStrategy and its subclasses in JDBC module public as well?
I have the PR ready for this, waiting for the approval. CC: @schauder@mp911de
The text was updated successfully, but these errors were encountered:
We really need the logic encapsulated in the DeclaredQueryLookupStrategy and CreateQueryLookupStrategy. If we made them public as well, that would be great and that would work. May I provide the PR? I have the code ready.
We're writing our own dialect for the Spring Data JDBC aiming to support YDB. And we hit the problem: ydb-platform/ydb-java-dialects#173
The summary is that we seems to need to extend the
QueryLookupStrategy
. That is not a big deal, since it is public, however, we want to retian the logic of theRowMapper
selection mechanism, as well as resolution of theStringBased
/PartTree
queries. This logic is outlined in theJdbcQueryLookupStrategy
, which is apparently notpublic
.Proposal: Since the
QueryLookupStrategy
is constructed inJdbcRepositoryFactory
, therefore it actually is intended to be overloaded, can we make theJdbcQueryLookupStrategy
and its subclasses in JDBC module public as well?I have the PR ready for this, waiting for the approval. CC: @schauder @mp911de
The text was updated successfully, but these errors were encountered: