Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdbcConverterRef to @EnableJdbcRepositories #1005

Closed
wants to merge 3 commits into from

Conversation

kota65535
Copy link

@kota65535 kota65535 commented Jul 13, 2021

Resolves #544, #994

@pivotal-cla
Copy link

@kota65535 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@kota65535 Thank you for signing the Contributor License Agreement!

Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #994 we should not add jdbcConverterRef but a reference to the JdbcAggregateOperations.

@schauder schauder removed the status: waiting-for-triage An issue we've not yet triaged label Oct 20, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 20, 2021
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 3, 2021
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed type: enhancement A general enhancement labels Mar 6, 2023
@mp911de
Copy link
Member

mp911de commented Mar 6, 2023

Thank you for your suggestion. We decided to take a different approach (see #994) so we're closing this pull request.

@mp911de mp911de closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple datasources support [DATAJDBC-321]
5 participants