DATAJDBC-356 - Support for reading large resultsets #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2021
spring-projects-issues
added
the
status: waiting-for-triage
schauder
requested changes
Jan 15, 2021
There was a problem hiding this comment.
Excellent PR.
I have just the single request to change the behaviour in the presence of a ResultSetExtractor.
As another side note: The "Closes" and "Original pull request" should reference the github issue number and the number of this PR.
But I'm happy to add these when merging
...ata-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/AbstractJdbcQuery.java
Outdated
Show resolved
Hide resolved
...ata-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/AbstractJdbcQuery.java
Show resolved
Hide resolved
schauder
added
status: waiting-for-feedback
denniseffing
force-pushed
the
issue/DATAJDBC-356
branch
2 times, most recently
from
182faef to
b24cb44
Compare
|
@schauder I finally got to finish this up! |
spring-projects-issues
added
status: feedback-provided
Use queryForStream for streamed query results. ResultSetExtractor is ignored because it cannot be used together with streams. Closes spring-projects#356
Specifying a custom result set extractor doesn't make sense when using streams because the result set extractor always considers the entire result. This loads the entire stream into memory anyways.
denniseffing
force-pushed
the
issue/DATAJDBC-356
branch
from
b24cb44 to
e23842b
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for reading large result sets using the new
queryForStreammethods in Spring Framework 5.3.