Introduce WebMvc.fn #22540
Merged
Introduce WebMvc.fn #22540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclozel
approved these changes
Mar 8, 2019
...mvc/src/main/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilder.java
Show resolved
Hide resolved
This commit introduces Servlet.fn, a servlet-based version of WebFlux.fn, i.e. HandlerFunctions and RouterFunctions. This commit contains the web framework only, further commits provide tests and DispatcherServlet integration. See spring-projectsgh-21490
This commit adds tests for Servlet.fn, the servlet-based version of HandlerFunctions and RouterFunctions. See spring-projectsgh-21490
This commit adds support for HandlerFunctions and RouterFunctions to DispatcherServlet, in the form of a HandlerAdapter and HandlerMapping. See spring-projectsgh-21490
This commit incoporates the remarks made during the Servlet.fn review. See spring-projectsgh-21490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Servlet.fn, a servlet-based version of HandlerFunctions and RouterFunctions.
To make it easier to review, I've split the PR into four commits:
I will set up a meeting for the review.