Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project icon #34444

Closed
wants to merge 1 commit into from
Closed

Add project icon #34444

wants to merge 1 commit into from
+54 −1

Conversation

pankratz76
Copy link

@pankratz76 pankratz76 commented Feb 18, 2025 •
edited
Loading

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 18, 2025
@pankratz76 pankratz76 marked this pull request as ready for review February 18, 2025 10:12
@sdeleuze sdeleuze self-assigned this Feb 18, 2025
@sdeleuze sdeleuze added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 18, 2025
@sdeleuze sdeleuze added this to the 6.2.4 milestone Feb 18, 2025
@sdeleuze
Copy link
Contributor

sdeleuze commented Feb 18, 2025 •
edited
Loading

Please update your PR to use https://spring.io/img/projects/spring-framework.svg instead and to add a Signed-off-by trailer as documented in https://github.com/spring-projects/spring-framework/blob/main/CONTRIBUTING.md#submit-a-pull-request.

@sdeleuze sdeleuze added the status: waiting-for-feedback We need additional information before we can continue label Feb 18, 2025
@pankratz76 pankratz76 force-pushed the add-project-icon branch 2 times, most recently from 7f25c9c to 6f4ff50 Compare February 18, 2025 16:20
@pankratz76
Copy link
Author

Thanks for the learning

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 18, 2025
@sdeleuze
Copy link
Contributor

I meant, .idea/icon.svg is supported, so I am suggesting to use it directly instead of generating a PNG from it.

@sdeleuze
Copy link
Contributor

Also please use only one Signed-off-by: line if possible in the commit (not sure which one should be used).

@sdeleuze sdeleuze added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Feb 18, 2025
@pankratz76
Copy link
Author

I was wondering myself, nicely done @sdeleuze 👍

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 18, 2025
@bclozel
Copy link
Member

bclozel commented Feb 18, 2025

Shouldn't the icon be resized to be a square? See https://github.com/junit-team/junit5/pull/2240/files for an example.

@pankratz76
Copy link
Author

We could use a sized PNG or an SVG, as SVG is sizeless since it's a vector-based format that scales without losing quality. I'm happy to apply any image you want—just let me know.

@sdeleuze
Copy link
Contributor

sdeleuze commented Feb 18, 2025 •
edited
Loading

I made various tries, the SVG looks the nicest option to me, it adapts to light or dark themes, scale to the required size, and seems recommended in IDEA doc. Is it fine for you @bclozel ?

@pankratz76 pankratz76 mentioned this pull request Feb 18, 2025
Merged
@sdeleuze sdeleuze removed the status: feedback-provided Feedback has been provided label Feb 19, 2025
@sdeleuze sdeleuze closed this in 6f596e2 Feb 19, 2025
@sdeleuze
Copy link
Contributor

Merged, thanks.

@pankratz76
Copy link
Author

Awesome, thank you very much.

@pankratz76 pankratz76 mentioned this pull request Feb 19, 2025
Closed
This was referenced Feb 24, 2025
Merged
Closed
pankratz76 pushed a commit to pankratz76/spring-framework that referenced this pull request Feb 24, 2025
@pinguin3245678
Add a project icon for IntelliJ IDEA
8364f9a 
The icon comes from https://spring.io/img/projects/spring-framework.svg.

Closes spring-projectsgh-34444
Signed-off-by: Vincent Potucek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdeleuze sdeleuze

Labels
type: task A general task
Projects
None yet
Milestone
6.2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@pankratz76 @sdeleuze @bclozel @spring-projects-issues @pinguin3245678