Skip to content

Configure JSON GraphQlModule in client support #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Apr 15, 2025 · 0 comments
Closed

Configure JSON GraphQlModule in client support #1190

bclozel opened this issue Apr 15, 2025 · 0 comments
Assignees
@bclozel
Labels
in: core Issues related to config and core support status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@bclozel
Copy link
Member

bclozel commented Apr 15, 2025

The various GraphQL clients supported in this project automatically detect JSON codecs for reading/writing GraphQL requests as JSON payloads. If there is none detected, clients provide a default codec instance.

We should configure automatically the GraphQlModule from #1174 in default codecs and add integration tests for FieldValue<T> usage on the client side.
@bclozel bclozel added in: core Issues related to config and core support type: enhancement A general enhancement labels Apr 15, 2025
@bclozel bclozel added this to the 1.4.0-RC1 milestone Apr 15, 2025
@bclozel bclozel self-assigned this Apr 15, 2025
bclozel added a commit that referenced this issue Apr 15, 2025
@bclozel
Revert ArgumentValue->FieldValue changes
ac9616f 
See gh-1187
See gh-1190
See gh-1174
@bclozel bclozel removed this from the 1.4.0-RC1 milestone Apr 15, 2025
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: core Issues related to config and core support status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bclozel