WIP: Split NamedChannel out of autoconfigure #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Dec 2, 2024
|
|
||
| import java.time.Duration; | ||
|
|
||
| public record NamedChannel(String address, |
There was a problem hiding this comment.
Of course, there will be more fields here (just a sample)
onobc
commented
Dec 2, 2024
| import org.springframework.core.env.Environment; | ||
| import org.springframework.core.env.StandardEnvironment; | ||
|
|
||
| public class NamedChannelRegistry implements EnvironmentAware, VirtualTargets { |
There was a problem hiding this comment.
This will handle the virtual targets lookups but its now divorced of config props.
onobc
commented
Dec 2, 2024
| @@ -48,14 +48,22 @@ ClientInterceptorsConfigurer clientInterceptorsConfigurer(ApplicationContext app | |||
| return new ClientInterceptorsConfigurer(applicationContext); | |||
| } | |||
|
|
|||
| @Bean | |||
| NamedChannelRegistry namedChannelRegistry(GrpcClientProperties properties) { | |||
There was a problem hiding this comment.
This is the abstraction used in core now
onobc
commented
Dec 2, 2024
| @@ -39,23 +36,16 @@ | |||
| import io.grpc.netty.NettyChannelBuilder; | |||
|
|
|||
| @ConfigurationProperties(prefix = "spring.grpc.client") | |||
| public class GrpcClientProperties implements EnvironmentAware { | |||
| public class GrpcClientProperties { | |||
There was a problem hiding this comment.
Note we still keep all the config props named channel variant here which is needed for type-safe config props, auto-completion in IDE, etc.. We just map them to the NamecChannel records in core (registry)
|
Closing in favor of #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.