GH-3734: Configure Gradle toolchain auto-provisioning #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit configures the Foojay resolver plugin in the Gradle build to auto-provision a required JDK distribution if it's not present already on the host. Signed-off-by: Suneet Kumar <[email protected]>
artembilan
reviewed
Feb 10, 2025
| @@ -7,6 +7,7 @@ pluginManagement { | |||
|
|
|||
| plugins { | |||
| id 'io.spring.develocity.conventions' version '0.0.22' | |||
| id 'org.gradle.toolchains.foojay-resolver-convention' version '0.9.0' | |||
There was a problem hiding this comment.
There is indeed something similar in Spring Framework: https://github.com/spring-projects/spring-framework/blob/main/settings.gradle#L4.
I'm not sure how well this works on every single platform, but we can give it a chance!
|
@suneetk92 Thanks for the PR. We are trying to see how to proceed with this from a framework standpoint since we might want to be consistent across the portfolio. Once that is clear, we can review and merge. |
|
Thanks @suneetk92. The PR is now merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3734
This commit configures the Foojay resolver plugin in the Gradle build to auto-provision a required JDK distribution if it's not present already on the host.