Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EmbeddedLdapServer Lifecycle Support #1027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve EmbeddedLdapServer Lifecycle Support #1027

wants to merge 1 commit into from

Conversation

etrandafir93
Copy link

Closes #1025

@etrandafir93 etrandafir93 force-pushed the dev/1025-unboundid_server_start_stop branch from d1b571a to 41b6afc Compare February 20, 2025 06:50
@jzheaux jzheaux changed the title Implement AutoClosable and add start() / stop() methods for LDAP server Improve LdapEmbeddedServer Lifecycle Support Feb 24, 2025
@jzheaux jzheaux changed the title Improve LdapEmbeddedServer Lifecycle Support Improve EmbeddedLdapServer Lifecycle Support Feb 24, 2025
@jzheaux jzheaux self-assigned this Feb 24, 2025
@jzheaux
Copy link
Collaborator

jzheaux commented Feb 24, 2025

Thanks for the updates, @etrandafir93. Are you able to add tests? Specifically, it would be nice to test calling start() after using the static method and to test calling close().

@etrandafir93 etrandafir93 force-pushed the dev/1025-unboundid_server_start_stop branch from 41b6afc to 8ee70ea Compare February 26, 2025 08:54
@etrandafir93
Add start/stop methods
d327843 
Closes spring-projects#1025

Signed-off-by: emanueltrandafir1993 <[email protected]>
@etrandafir93 etrandafir93 force-pushed the dev/1025-unboundid_server_start_stop branch from 8ee70ea to d327843 Compare February 26, 2025 09:02
@etrandafir93
Copy link
Author

Thanks for the updates, @etrandafir93. Are you able to add tests? Specifically, it would be nice to test calling start() after using the static method and to test calling close().

That makes sense @jzheaux - I have added three tests now and I've tried to keep them relatively simple. In terms of asserting, I have only checked whether the port is opened or not. Do you agree with this, or should I try to come up with more elaborate tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: core type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add start() and stop() methods for unboundid.EmbeddedLdapServer
2 participants
@etrandafir93 @jzheaux